Skip to content

Fix cargo install#300

Merged
MordechaiHadad merged 2 commits into
MordechaiHadad:masterfrom
jamesharris-garmin:fix-cargo-install
Jul 27, 2025
Merged

Fix cargo install#300
MordechaiHadad merged 2 commits into
MordechaiHadad:masterfrom
jamesharris-garmin:fix-cargo-install

Conversation

@jamesharris-garmin

Copy link
Copy Markdown
Contributor

Addressing #298, It looks like the correct fix was to update the offending package to 0.18.0 and fix api calls that styled the progress bar to use the new API around template calls.

Tested with:

cargo install --git https://github.com/jamesharris-garmin/bob --branch fix-cargo-install

which builds and installs correctly.

@brandonyoungdev brandonyoungdev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix

@MordechaiHadad

Copy link
Copy Markdown
Owner

Thanks for the PR, just fix some of these errors here. Pretty interesting this is the second time 2 people created a PR addressing the same issue, and for this one: #294

@jamesharris-garmin

Copy link
Copy Markdown
Contributor Author

yea, I couldn't figure out where to put the ? operator but the changes that did work for me were taken from with indicatif's documentation.

I also bumped dialoguer because it depends on the console and I wanted to minimize versions of console that were running around in the application since rust vendors every build requirement's version of a crate that they need individually if they can't de-duplicate the dependency.

@MordechaiHadad MordechaiHadad merged commit 1bdbcc8 into MordechaiHadad:master Jul 27, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to install latest builds on Ubuntu 22.04 nvim-bob Installation failure via cargo on Ubuntu 24.04.2 LTS

3 participants