Skip to content

warn FreeBSD users they'll need Linux compatibilty for Bob#290

Merged
MordechaiHadad merged 1 commit into
MordechaiHadad:masterfrom
penryu:fix/error-on-freebsd
Jun 30, 2025
Merged

warn FreeBSD users they'll need Linux compatibilty for Bob#290
MordechaiHadad merged 1 commit into
MordechaiHadad:masterfrom
penryu:fix/error-on-freebsd

Conversation

@penryu

@penryu penryu commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Potential fix #289

Does not exhaustively fix each target_os check, but catches unsupported platforms early enough in the invocation that bob doesn't go too far down a bad path.

I'm open to addressing in different places and ways, if anyone has a better picture of how this should work.

@MordechaiHadad

MordechaiHadad commented Jun 29, 2025

Copy link
Copy Markdown
Owner

Hmm I think a better way is what you suggested stopping it from compiling by creating a build.rs checking for the current OS and running a panic, although hmmm this will only address freebsd and not other supported platforms. Will have to think about that.

@penryu

penryu commented Jun 29, 2025

Copy link
Copy Markdown
Contributor Author

I updated #289 with some info about FreeBSD's Linux compat layer, that does allow FreeBSD users to run Linux binaries directly, and enables the use of bob on FreeBSD simply by installing/enabling 2 additional items.

For the first proposed approach to fix, it wouldn't require changing the cfg test tree at all, and would just be a single log warning the user of the requirements and pointing to the FreeBSD Handbook.

I can rework this MR to that later today if you like the approach.

@penryu penryu force-pushed the fix/error-on-freebsd branch from 61eb8b0 to bc58445 Compare June 30, 2025 03:01
@MordechaiHadad

Copy link
Copy Markdown
Owner

I like this newer approach

@penryu penryu force-pushed the fix/error-on-freebsd branch from bc58445 to 8d38f04 Compare June 30, 2025 09:24
@penryu

penryu commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

Push. Also patched a couple lints that seemed to be blocking pipelines.

@penryu penryu force-pushed the fix/error-on-freebsd branch from 8d38f04 to 2f3e6d8 Compare June 30, 2025 10:09
@penryu penryu changed the title fix: exit early with non-zero status on non-supported platforms warn FreeBSD users they'll need Linux compatibilty for Bob Jun 30, 2025
@MordechaiHadad MordechaiHadad merged commit 3e5cfbf into MordechaiHadad:master Jun 30, 2025
27 checks passed
@penryu penryu deleted the fix/error-on-freebsd branch June 30, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bob installs Linux binary on FreeBSD systems

2 participants