build: add cargo-binstall support#288
Merged
MordechaiHadad merged 1 commit intoJun 26, 2025
Merged
Conversation
Owner
|
Really cool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
cargo binstallby adding the manifest fields to theCargo.tomlaccording to this documentation.cargo binstallreads the manifest to automatically install binaries instead of building. Currently cargo-binstall will install from quick install which installs incorrect binaries on macos (x86_64 instead of arm).An alternative to changing the manifest is to change the names of the release artifacts so that it can be automatically detected by
cargo binstall. Let me know if this is preferred.Tested by running and verifying architecture with
file:cargo binstall --force --manifest-path . --root . bob-nvim, installed the arm version on my mac correctlycargo binstall --force --targets <target> --manifest-path . --root . bob-nvim<target>were tested:aarch64-apple-darwinx86_64-apple-darwinx86_64-pc-windows-msvcx86_64-unknown-linux-gnu