fix: use exec to replace child process on unix systems#262
Merged
Conversation
Owner
|
oh shit this is cool af didnt know this existed, could you delete this depdency as well: https://github.com/MordechaiHadad/bob/blob/master/Cargo.toml#L86 IIRC we only use it for forwarding the killing signal to neovim so this isn't needed anymore (unless we use it for other shit which i doubt) |
Contributor
Author
|
@MordechaiHadad done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My CPU gets pegged at 100% and if I strace, I see a loop of
wait4calls. Instead of creating a sub-process and waiting for it to complete, the proxy can simply replace itself with the nvim process.