Update README.md troubleshooting section#248
Merged
Merged
Conversation
Disabling secure_path is considered unsafe. I've suggested a safer workaround to get around secure_path.
Owner
|
Shalom, toda for the PR looks good, could you include your username to this: "These workarounds were devised by @nfejzic, thanks to him." |
Added my username to the troubleshooting credits.
Contributor
Author
|
Great! I've added my username. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling secure_path is considered unsafe as it allows sudo to run commands from directories that can be modified by any user. I've suggested a safer workaround to get around secure_path without disabling it. Let me know what you think.