ES8311 Support #168
Merged
ES8311 Support #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Worth merging even if it's a little temperamental? |
Collaborator
Author
I guess? The code works just fine, it's the I2C commands that seem to need a tweak. It would be good to have it in mdev so it's there when people come across it - and then can report bugs. Also the entire installed user base for the ES8311 is likely just me at the moment. 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was a bit more messy to add, as there's a lot of bits to be set for proper MCLK division that I can't claim to fully understand, but reverse-engineered from the Espressif driver and some other hints I found.
Initializes properly for the ES8311 chip found on the ESP32-P4 EV board with integrated mic, but should likely work for other implementations as it's a very simple codec chip that that only has mic input.
It frustratingly works,,, most of the time. Sometimes it absolutely comes up in the wrong state. Looking into it still, but it is generally functional.
I think it's something to do with Auto Gain Control in the codec chip for the mic. Might be fighting with the same sort of logic in WLED.