Skip to content

[MGCB Editor] Update registration handling files#7311

Merged
Jjagg merged 2 commits intoMonoGame:developfrom
harry-cpp:fix-mgcb-editor-install-unix
Aug 17, 2020
Merged

[MGCB Editor] Update registration handling files#7311
Jjagg merged 2 commits intoMonoGame:developfrom
harry-cpp:fix-mgcb-editor-install-unix

Conversation

@harry-cpp
Copy link
Copy Markdown
Member

@harry-cpp harry-cpp commented Aug 15, 2020

  • Some code formatting/improved readability for Mac and Linux FileAssociation files
  • Removed all messages about association except the final result message
  • Failed registration now always gives a stacktrace
  • Unassociation is now always called before Association

Fixes #7309

@harry-cpp
Copy link
Copy Markdown
Member Author

I'm testing the changes I made with this, I'll post another comment once this has been fully tested.

@harry-cpp harry-cpp force-pushed the fix-mgcb-editor-install-unix branch from a1e56e2 to 7ee86a5 Compare August 15, 2020 20:13
- Some code formatting/improved readability for Mac and Linux FileAssociation files
- Removed all messages about association except the final result message
- Failed registration now always gives a stacktrace
- Unassociation is now always called before Association
@harry-cpp harry-cpp force-pushed the fix-mgcb-editor-install-unix branch from 7ee86a5 to ec3b0f4 Compare August 15, 2020 22:01
@harry-cpp
Copy link
Copy Markdown
Member Author

This is ready to go.

@harry-cpp harry-cpp added this to the 3.8.1 milestone Aug 16, 2020
@Jjagg Jjagg merged commit b2915a7 into MonoGame:develop Aug 17, 2020
@harry-cpp harry-cpp deleted the fix-mgcb-editor-install-unix branch August 17, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running "mgcb-editor --register" on a Mac a second time causes exception

2 participants