Skip to content

Improve native library loading#7063

Merged
Jjagg merged 1 commit intoMonoGame:developfrom
harry-cpp:betterlibloading
Mar 24, 2020
Merged

Improve native library loading#7063
Jjagg merged 1 commit intoMonoGame:developfrom
harry-cpp:betterlibloading

Conversation

@harry-cpp
Copy link
Copy Markdown
Member

Stuff done:

  • Added rid to the CurrentPlatform helper class
  • Moved the library handling logic to FuncLoader
  • Fixed library search locations for .NET Core
  • Better explained each search location
  • Inform the user about library that failed to load in the exception itself

@harry-cpp
Copy link
Copy Markdown
Member Author

@tomspilman @Jjagg Can anyone merge this?

@Jjagg
Copy link
Copy Markdown
Contributor

Jjagg commented Mar 23, 2020

@harry-cpp did you test this on Win/Mac/Linux? Don't want to have lib loading in a broken state.

@harry-cpp
Copy link
Copy Markdown
Member Author

Why of course. And its in a broken state right now XD

@ryancheung
Copy link
Copy Markdown
Contributor

I tested it in macOS, it works right now.

@Jjagg Jjagg merged commit 4f4984a into MonoGame:develop Mar 24, 2020
@harry-cpp harry-cpp deleted the betterlibloading branch March 24, 2020 11:12
@harry-cpp harry-cpp added this to the 3.8 Release milestone Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants