Add custom css file#134
Conversation
for the future: add a panel in settings to change the file in the webbrowser, like in organizr for example.
|
@rob1998 I'll look into this. Thanks! |
- Added a settings page to change the custom css file, this should be tested, might need some more checks etc. - Added the pihole logo as image - Show all the log messages, instead of only 1
|
I completed a settings page to change the custom.css file, integrated the custom.css file on every page and did some more things. |
|
@rob1998 I'm gonna implement the css thing, it's good! The marquee needs work. I messed with it for a bit. The problem is that the marquee is a client-side JS framework, and PHP is obv server-side, so with respect to dynamically updated the DIV (where the PHP script runs to check for the presence of the offline.json file) the js script will NOT update if there are changes. So it works on page-load, but because the DIV is already loaded into the DOM, it won't update dynamically when the PHP script updates. So, just have to do a bit more work on that. Will probably have to use some type of an AJAX call, and/or move the entire JS function to an external file so we can call it w/ ajax. Thanks for helping out my man! Good stuff. Also, for future ref - try to push "features" in different PRs. Makes it a lot easier to merge into the code. |
The marquee has been replaced by a full jQuery/Ajax/PHP solution
|
@rob1998 thanks for this! can you merge our latest pushes and adjust for the differences? |
|
tracking with #141 |
|
Continue in the new pull request please. |
for the future: add a panel in settings to change the file in the webbrowser, like in organizr for example.