Skip to content
This repository was archived by the owner on Nov 15, 2025. It is now read-only.

Update supported apps#935

Merged
Samuel12321 merged 18 commits intoModernFlyouts-Community:mainfrom
MuhammetEminCakir:patch-1
Apr 6, 2022
Merged

Update supported apps#935
Samuel12321 merged 18 commits intoModernFlyouts-Community:mainfrom
MuhammetEminCakir:patch-1

Conversation

@MuhammetEminCakir
Copy link
Copy Markdown
Contributor

No description provided.

@Samuel12321 Samuel12321 self-requested a review January 31, 2022 21:25
Copy link
Copy Markdown
Member

@Samuel12321 Samuel12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MuhammetEminCakir thanks so much for the pr, would you mind re ordering as I suggested in the comments.

| [VLC (UWP)](https://www.microsoft.com/store/productId/9NBLGGH4VVNH) | 🟢 | 🟩 | 🟩 | 🟩 | 🟩 | 🟩 | 🟩 | 🟩 | 🟥 | 🟥 | 🟩 | 🟥 |
| [MPC-BE](https://sourceforge.net/projects/mpcbe/) | 🟢 | 🟩 | 🟩 | 🟩 | 🟥 | 🟩 | 🟩 | 🟩 | 🟥 | 🟥 | 🟥 | 🟥 |
| [MPV](https://mpv.io/installation/) | 🟡 | 🟩 | 🟩 | 🟩 | 🟩 | 🟩 | 🟩 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 |
| [VLC (Desktop)](https://www.videolan.org/vlc/) | 🔴 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps reorder to keep vlc uwp and desktop together

@Samuel12321
Copy link
Copy Markdown
Member

This will probably be merged directly into the 0.11-final branch.

@MuhammetEminCakir
Copy link
Copy Markdown
Contributor Author

@ShankarBUS
I found a plugin for VLC.

@MuhammetEminCakir
Copy link
Copy Markdown
Contributor Author

@Samuel12321
What are you thinking about design of MPV's plugins informafion

@MuhammetEminCakir
Copy link
Copy Markdown
Contributor Author

image
Can i delete this section? Because VLC(Desktop) already supports SMTC with an plugin.
@Samuel12321

@Samuel12321
Copy link
Copy Markdown
Member

No, that is a link to a request for build in support (without plugin)

@MuhammetEminCakir MuhammetEminCakir changed the title Added some apps Update supported apps Feb 8, 2022
@MuhammetEminCakir
Copy link
Copy Markdown
Contributor Author

Can i add a "Others" category for Discord etc?

@prakharb5
Copy link
Copy Markdown
Member

Which other apps do you plan to add to this category? Except Discord, that is.

@MuhammetEminCakir
Copy link
Copy Markdown
Contributor Author

I'm not sure. But pretty sure Discord isn't a media player. Maybe WhatsApp, Telegram and android emulators

@prakharb5
Copy link
Copy Markdown
Member

I feel, we will keep it limited to media apps, since that is the main purpose of the media flyout.

@Samuel12321 what do you think?

@MuhammetEminCakir
Copy link
Copy Markdown
Contributor Author

should i remove the Discord?

@prakharb5
Copy link
Copy Markdown
Member

That would be better, yes.

@Samuel12321 Samuel12321 added this to the 0.11.0 milestone Mar 26, 2022
Copy link
Copy Markdown
Member

@Samuel12321 Samuel12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress, thanks so much for your help

Just noticed Media Player (grove) is incorrect, it doesnt show media title

| [VLC (Desktop)](https://www.videolan.org/vlc/) | 🔴 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 |
| [PotPlayer](https://daumpotplayer.com/download/) | 🔴 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 |
| [MPC-HC (clsid2)](https://github.com/clsid2/mpc-hc) | 🔴 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 |
| [Amazon Prime Video](https://www.microsoft.com/store/productId/9P6RC76MSMMJ) | 🔴 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 | 🟥 |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move above MPV and MPc as probably more common.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. Should i move above mpv or mpc?

MuhammetEminCakir and others added 3 commits March 29, 2022 09:10
Changed Media Title support
Removed Preview name
Added MS Edge and Google chrome - even though they are chromium based just to clarify for users who dont know this as they are the most popular browsers.
@Samuel12321 Samuel12321 merged commit cdb34dd into ModernFlyouts-Community:main Apr 6, 2022
@Samuel12321
Copy link
Copy Markdown
Member

Looking Great, thanks for all your help @MuhammetEminCakir
Was going to wait till 0.11 release to merge, but as it is an important document that has been significantly updated will merge it now.
Any further improvements just open another PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants