Skip to content
This repository was archived by the owner on Nov 15, 2025. It is now read-only.

Improved French language#644

Merged
Samuel12321 merged 3 commits intoModernFlyouts-Community:mainfrom
thomasbnt:improve_french_translation_thomasbnt
Oct 20, 2021
Merged

Improved French language#644
Samuel12321 merged 3 commits intoModernFlyouts-Community:mainfrom
thomasbnt:improve_french_translation_thomasbnt

Conversation

@thomasbnt
Copy link
Copy Markdown
Contributor

Added French language to Layout part.

@thomasbnt
Copy link
Copy Markdown
Contributor Author

Hello, can you review this PR @Stealnoob ?

Copy link
Copy Markdown
Contributor

@stlnb stlnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a long time i haven't been there, but here is my review.
There's things here and there, but for the other stuff, that's good.

One thing though : "flyout" should be translated to "menu volant", as it's the translation used in the few Microsoft Docs pages that have the word and are manually translated in French. Yes, it seems somewhat weird, but like i don't think we have a proper and consistent translation for it, so might be better using that.
I noted all the comments in that regard with /F/, so you can notice them easily.

@thomasbnt
Copy link
Copy Markdown
Contributor Author

Request review for @Stealnoob after changed some words and added two missed translations.

Copy link
Copy Markdown
Contributor

@stlnb stlnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's good now, i don't have anything to add.

@Samuel12321
Copy link
Copy Markdown
Member

Thanks so much @thomasbnt and @Stealnoob for your help.
I'll merge this once the plan for the next release has been finalised. This will be part of either 0.9.4 or 0.10.

@Samuel12321 Samuel12321 added this to the 0.10 milestone Jun 19, 2021
@Samuel12321 Samuel12321 modified the milestones: 0.11.0, 0.10.0 Aug 4, 2021
@thomasbnt
Copy link
Copy Markdown
Contributor Author

Hello, no update for that?

@thomasbnt
Copy link
Copy Markdown
Contributor Author

Hello @Cyberdroid1, I corrected the conflicts and still work!

@prakharb5
Copy link
Copy Markdown
Member

@thomasbnt This PR will be merged as soon as the 0.10 release is finalised. You need not worry :)

@Samuel12321
Copy link
Copy Markdown
Member

this will be visible in 0.10
Sorry for the delay, thanks for your help.

@Samuel12321 Samuel12321 merged commit 9ac7c17 into ModernFlyouts-Community:main Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants