Skip to content
This repository was archived by the owner on Nov 15, 2025. It is now read-only.

Polish Patch#627

Merged
Samuel12321 merged 15 commits intomainfrom
dont-readme
Jun 4, 2021
Merged

Polish Patch#627
Samuel12321 merged 15 commits intomainfrom
dont-readme

Conversation

@prakharb5
Copy link
Copy Markdown
Member

No description provided.

@prakharb5
Copy link
Copy Markdown
Member Author

dont merge it. i will do on my own

@prakharb5 prakharb5 marked this pull request as ready for review May 22, 2021 17:45
@Samuel12321
Copy link
Copy Markdown
Member

why is it marked polish update, there are no changes to polish translations?

@prakharb5
Copy link
Copy Markdown
Member Author

prakharb5 commented May 23, 2021

why is it marked polish update, there are no changes to polish translations?

I am "polishing" the readme, thats why the name.

Even Discord made an update and named it "Polish Patch" :D

I need to make some changes to the banner, hence marking it as draft.

@prakharb5 prakharb5 marked this pull request as draft May 23, 2021 04:49
@Samuel12321
Copy link
Copy Markdown
Member

oh right my mistake, i thought you meant polish as in the language 😉

@ShankarBUS
Copy link
Copy Markdown
Member

@Cyberdroid1 bruh

@prakharb5 prakharb5 changed the title Polish Update Polish Patch May 23, 2021
@prakharb5
Copy link
Copy Markdown
Member Author

Lets add screenshots with this pull request, shall we?

@prakharb5 prakharb5 added the Documentation Improvements or additions to documentation label May 24, 2021
@prakharb5
Copy link
Copy Markdown
Member Author

How about fixing #58 with this PR? Since the content is similar anyway

@Samuel12321
Copy link
Copy Markdown
Member

We can certainly look into options for the store page, however the store images need to be high res preferably vector images.

emojis in headings
@prakharb5
Copy link
Copy Markdown
Member Author

Please see and give feedback on usage of emojis.

@Samuel12321
Copy link
Copy Markdown
Member

Samuel12321 commented May 28, 2021

@Cyberdroid1 Perhaps change the contributors / translators list to a link to https://github.com/ModernFlyouts-Community/ModernFlyouts/graphs/contributors
to shorten readme page

@prakharb5
Copy link
Copy Markdown
Member Author

Sounds good!

How about removing the whole section altogether? The main page shows the contributors list anyway
image

@ShankarBUS give views

@Samuel12321
Copy link
Copy Markdown
Member

i still think we should have a brief thing saying thanks ... with a link.

@prakharb5
Copy link
Copy Markdown
Member Author

I just had a big-brain idea. How about we create a text file in the repo named "Contributors.md" which will contain this stuff.

@Samuel12321
Copy link
Copy Markdown
Member

isn't it a bit redundant, plus means we have to maintain it - the GitHub contributors page updates automatically

@prakharb5
Copy link
Copy Markdown
Member Author

Hm, good point. Will do what you said, adding a link.

@prakharb5
Copy link
Copy Markdown
Member Author

@Samuel12321 does this look fine?

Copy link
Copy Markdown
Member

@Samuel12321 Samuel12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, however i probably wouldn't say most importantly localisation as all contributions are helpful

@prakharb5
Copy link
Copy Markdown
Member Author

prakharb5 commented May 28, 2021

looks good, however i probably wouldn't say most importantly localisation as all contributions are helpful

well, most of our contributions are mainly localisation lol.

will edit it accordingly if really needed.

@Samuel12321
Copy link
Copy Markdown
Member

@Cyberdroid1 what's the plan for merging this?

Only changes that need to be made are "most importantly localisation" and the chocolatey stuff should be below winget as we should prioritise supported distributions.

@prakharb5
Copy link
Copy Markdown
Member Author

I will make the changes you said.

I need to make screenshots too, just trying to find some time to make those 😅

@Samuel12321 Samuel12321 marked this pull request as ready for review June 4, 2021 04:22
@Samuel12321 Samuel12321 merged commit e93fb0b into main Jun 4, 2021
@Samuel12321 Samuel12321 deleted the dont-readme branch June 4, 2021 04:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants