Skip to content
This repository was archived by the owner on Nov 15, 2025. It is now read-only.

Implement toggle for displaying thumbnail image in the background #315

Merged
Samuel12321 merged 2 commits intoModernFlyouts-Community:mainfrom
fheck:feature/224
Dec 17, 2020
Merged

Implement toggle for displaying thumbnail image in the background #315
Samuel12321 merged 2 commits intoModernFlyouts-Community:mainfrom
fheck:feature/224

Conversation

@fheck
Copy link
Copy Markdown
Contributor

@fheck fheck commented Dec 17, 2020

I looked into implementing it myself and found it relatively easy. I hope I found everything I needed to adapt. If there is anything I missed, just tell me and I will try to fix it.

Implements #224

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 17, 2020

Wow!

Thank you so much mate! I was distracted away by some other things. Thanks again.

I will look into it as the first thing in the morning. Keep this for now ❤

ShankarBUS
ShankarBUS suggested changes Dec 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@ShankarBUS ShankarBUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please correct those suggestions?
Or else I could do that after merging.

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 17, 2020

Wow! That was quick.

@Samuel12321, merge this marvel!

@fheck
Copy link
Copy Markdown
Contributor Author

fheck commented Dec 17, 2020

I have made the requested changes. I have some experience with C#, but I haven't done much with xmal, so I wasn't aware there is a simpler way.
That was a fun evening project, so I just did it now😃.

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 17, 2020

Also thanks for the free translations lol. Saves us some time.

@fheck
Copy link
Copy Markdown
Contributor Author

fheck commented Dec 17, 2020

I only speak English and German, so I can't help with the other ones, but I'm happy to do those I know.

Samuel12321
Samuel12321 approved these changes Dec 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Samuel12321 Samuel12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks so much for your help

This was linked to issues Dec 17, 2020
Feature Request: Option to disable backgroud media image #314
Closed
Feature Request: Option to toggle the album art background for media controls #224
Closed
@Samuel12321 Samuel12321 merged commit 0943f18 into ModernFlyouts-Community:main Dec 17, 2020
@Renzo904 Renzo904 mentioned this pull request Dec 30, 2020
Closed
@ShankarBUS ShankarBUS mentioned this pull request Jan 3, 2021
Closed
@ShankarBUS ShankarBUS mentioned this pull request Jan 18, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ShankarBUS ShankarBUS ShankarBUS requested changes

@Samuel12321 Samuel12321 Samuel12321 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Option to disable backgroud media image Feature Request: Option to toggle the album art background for media controls

3 participants

@fheck @ShankarBUS @Samuel12321