Skip to content
This repository was archived by the owner on Nov 15, 2025. It is now read-only.

a minor translation update for zh-CN and zh-Hans#219

Merged
Samuel12321 merged 1 commit intoModernFlyouts-Community:mainfrom
imgradeone:main
Nov 18, 2020
Merged

a minor translation update for zh-CN and zh-Hans#219
Samuel12321 merged 1 commit intoModernFlyouts-Community:mainfrom
imgradeone:main

Conversation

@imgradeone
Copy link
Copy Markdown
Contributor

@imgradeone imgradeone commented Nov 14, 2020

  • Fixed an unnecessary translation
  • Fixed a translation with a small issue (my mistake :( )

Original: If you find any bugs, please open a new issue in the github repository.
Legacy translation: 如果发现任何 bug，请在 GitHub 仓库中打创建一个新 Issue。
New translation: 如果发现任何 bug，请在 GitHub 仓库中创建一个新 Issue。

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Nov 14, 2020 •
edited
Loading

@Samuel12321,

Aren't zh-Hans & zh-Hant enough?

Why is zh-CN there additionally?

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Nov 14, 2020 •
edited
Loading

@imgradeone,

What are the differences between zh-Hans, zh-Hant, zh-CN & zh-TW?

I'm confused 😅.

@imgradeone
Copy link
Copy Markdown
Contributor Author

imgradeone commented Nov 14, 2020 •
edited
Loading

@ShankarBUS #104 (comment)

Hello, the default simplified Chinese language of Windows is zh-CN, and in the latest version 0.7.8.0, the simplified Chinese and traditional Chinese added in the program are zh-Hans and zh-Hant respectively, which do not match zh-CN, so it may be the cause of the problem.

maybe that's why 😂

but they are exactly the same, though (imo)

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Nov 14, 2020

Oh ok 😄

@Samuel12321
Copy link
Copy Markdown
Member

Samuel12321 commented Nov 14, 2020 •
edited
Loading

From what i understand zk-CN is a subset of zh-hans.
I added zh-CN due to reports that zh-hans wasn't automatically being set for people with display language set to zh-CN. I assumed this was because it wasn't the same language code even though they were the same. To fix this i also added zh-CN.

@imgradeone
Copy link
Copy Markdown
Contributor Author

imgradeone commented Nov 17, 2020 •
edited
Loading

so, merge, when? :(

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Nov 18, 2020

Hey @Samuel12321,

Could you merge this ASAP?

@Samuel12321 Samuel12321 merged commit adac847 into ModernFlyouts-Community:main Nov 18, 2020
@ShankarBUS ShankarBUS mentioned this pull request Nov 24, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imgradeone @ShankarBUS @Samuel12321