Skip to content

WIP: Archive preview support#14

Merged
Holt59 merged 1 commit intomasterfrom
dev/archive_preview
Jul 11, 2024
Merged

WIP: Archive preview support#14
Holt59 merged 1 commit intomasterfrom
dev/archive_preview

Conversation

@Silarn
Copy link
Member

@Silarn Silarn commented Jun 26, 2024

Add support for creating preview from data

@AnyOldName3
Copy link
Member

Nothing's leaping out at me as a potential problem so far

@Silarn
Copy link
Member Author

Silarn commented Jun 27, 2024

I've took a bit of a day off today but I intend to write the memory version to a file and compare it to a directly extracted version of the data.

I guess if those are functionally identical then we can figure out why it no work.

@Silarn Silarn marked this pull request as ready for review July 11, 2024 07:14
@Silarn Silarn requested review from AnyOldName3 and Holt59 July 11, 2024 08:13
@Silarn
Copy link
Member Author

Silarn commented Jul 11, 2024

The issue mentioned above stemmed from a mistake in libbsarch. This code should be good.

@Holt59 Holt59 merged commit acbcc67 into master Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants