fix: acceptance tests keep dropping errors for missing_required_column #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 8df6f0b 📊 Notices ComparisonNew Errors (0 out of 1802 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1802 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1802 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1802 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check25 out of 1827 sources (~1 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Member
Author
|
The acceptance test report shows an increased number of corrupted files. This is expected, as before, the report missed the feeds failing to download. Those feeds have a report JSON generated without notices and system errors with notices. |
Contributor
|
Should we add to the |
Member
Author
The cause might be different than just downloading the file. Any runtime exception that exits the validation process will count as |
qcdyx
approved these changes
Mar 11, 2025
...ain/java/org/mobilitydata/gtfsvalidator/outputcomparator/cli/ValidationReportComparator.java
Outdated
Show resolved
Hide resolved
Member
Author
Created a follow-up issue |
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit f1dfa6a 📊 Notices ComparisonNew Errors (0 out of 1802 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1802 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1802 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1802 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check25 out of 1827 sources (~1 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Feeds that failed to download or process with runtime exceptions were not marked as corrupted.
Expected behavior:
All feeds that failed to download or process with system error notices are marked as corrupted.
Closes: #2005
From our AI friend
This pull request introduces several changes to the
output-comparatormodule, primarily focused on enhancing the handling of system errors in validation reports. The key modifications include adding new command-line parameters for system error files, updating methods to accommodate these parameters, and improving error handling logic.Enhancements to command-line arguments and parameters:
output-comparator/src/main/java/org/mobilitydata/gtfsvalidator/outputcomparator/cli/Arguments.java: Added constants for system error file names and new command-line parametersreference_system_errors_nameandlatest_system_errors_name. [1] [2]Improved error handling and validation logic:
output-comparator/src/main/java/org/mobilitydata/gtfsvalidator/outputcomparator/cli/Arguments.java: Added getter and setter methods for the new system error file parameters.output-comparator/src/main/java/org/mobilitydata/gtfsvalidator/outputcomparator/cli/ValidationReportComparator.java: Updated thecompareValidationRunsmethod to include paths for the system error files and improved error handling by introducing thehasSystemErrorsmethod. [1] [2] [3]Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything