Skip to content

Conversation

@qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Aug 27, 2024

Summary:

Closes #1768

Expected behavior:

  • add rule priority to GtfsFareLegRuleSchema

  • dataset and screenshot are not included here due to data privacy

  • unknown_field not triggered in the report

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Aug 27, 2024 that may be closed by this pull request
@github-actions
Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit b434772
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1563 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1563 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.88 3.94 ⬆️+0.06
Median -- 1.34 1.40 ⬆️+0.05
Standard Deviation -- 11.18 11.24 ⬆️+0.06
Minimum in References Reports ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 0.50 0.53 ⬆️+0.03
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 317.47 317.77 ⬆️+0.30
Minimum in Latest Reports us-virginia-jaunt-inc-gtfs-1324 0.59 0.52 ⬇️-0.07
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 317.47 317.77 ⬆️+0.30

@qcdyx qcdyx requested review from emmambd and jcpitre August 27, 2024 19:27
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qcdyx qcdyx merged commit eb0d40a into master Aug 28, 2024
@qcdyx qcdyx deleted the 1768-add-rule_priority-field-to-fare-leg-rule-schema branch August 28, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rule_priority field to fare leg rule schema

4 participants