Skip to content

feat: documented the changes made in PR 1633 #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qcdyx merged 2 commits into from
May 8, 2024
Merged

feat: documented the changes made in PR 1633 #1748

qcdyx merged 2 commits into from
May 8, 2024

Conversation

@qcdyx
Copy link
Contributor

@qcdyx qcdyx commented May 8, 2024 •
edited
Loading

Summary:

Closes #1742

Expected behavior:

User should be able to see documentation about user agent header in the "Using web-based validator" heading of the README

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue May 8, 2024 that may be closed by this pull request
Document custom user-agent header #1742
Closed
@qcdyx qcdyx requested a review from emmambd May 8, 2024 15:16
davidgamez
davidgamez approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

emmambd
emmambd reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qcdyx Can we include the actual user agent string in the docs?

@qcdyx
Copy link
Contributor Author

qcdyx commented May 8, 2024 •
edited
Loading

@qcdyx Can we include the actual user agent string in the docs?

@emmambd It's a good idea! Done!

@qcdyx qcdyx merged commit 0d13c65 into master May 8, 2024
@qcdyx qcdyx deleted the 1742-document-custom-user-agent-header branch May 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidgamez davidgamez davidgamez approved these changes

@emmambd emmambd emmambd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document custom user-agent header

4 participants

@qcdyx @davidgamez @emmambd