Skip to content

Issue/1463 #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cka-y merged 3 commits into from
Jun 5, 2023
Merged

Issue/1463 #1471

cka-y merged 3 commits into from
Jun 5, 2023

Conversation

@cka-y
Copy link
Contributor

@cka-y cka-y commented Jun 2, 2023

Summary:

Add a "Shapes" GTFS Component#1463
Also introduced unit tests for GTFS components included in the report so far and a small formatting change to the "GTFS Components included" list.

Expected behavior:

Add "Shapes" component to the "GTFS Component included" list. We consider this component present if shapes.txt is present in the data and has at least one record.

Screenshot 2023-06-01 at 8 59 04 PM

Appearance before the formatting change
Screenshot 2023-06-01 at 9 02 14 PM

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@isabelle-dr
Copy link
Contributor

isabelle-dr commented Jun 2, 2023

Thank you for working on this @cka-y!
I have tested with SDMTS's dataset and it worked as expected (see screenshot below).
I have also tried to keep shapes.txt file in the data but delete all records, and the Shapes component wasn't appearing, which is the expected behavior.

Screenshot 2023-06-02 at 9 51 51 AM

isabelle-dr
isabelle-dr approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM in terms of expected behavior, this is not a code review!

@cka-y cka-y merged commit 287faf6 into MobilityData:master Jun 5, 2023
@cka-y cka-y deleted the issue/1463 branch June 5, 2023 13:54
@cka-y cka-y linked an issue Jun 5, 2023 that may be closed by this pull request
Add a "Shapes" GTFS Component #1463
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isabelle-dr isabelle-dr isabelle-dr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a "Shapes" GTFS Component

2 participants

@cka-y @isabelle-dr