Remove local and postgres includes from new exported header files#748
Merged
estebanzimanyi merged 1 commit intoMobilityDB:masterfrom Nov 27, 2025
Merged
Remove local and postgres includes from new exported header files#748estebanzimanyi merged 1 commit intoMobilityDB:masterfrom
estebanzimanyi merged 1 commit intoMobilityDB:masterfrom
Conversation
estebanzimanyi
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just removes the local and postgres includes in two exportable header files (makes PyMEOS build crash):
meos_pose.h: removestemporal/set.hmeos_rgeo.h: Removesgeo/stbox.handpostgres.h.For the postgres include in
meos_rgeo.h, initially I tried to do it as inmeos.h, where the import is different depending on theMEOSflag and then modified in the CMake, but it kept crashing when building PyMEOS because the definitions where repeated. Sincemeos_rgeo.himportsmeos.h, I figured I could remove it altogether.