Skip to content

Upgrade embedded PostGIS code to version 3.6#701

Merged
mschoema merged 1 commit intoMobilityDB:masterfrom
estebanzimanyi:postgis_3.6
Aug 28, 2025
Merged

Upgrade embedded PostGIS code to version 3.6#701
mschoema merged 1 commit intoMobilityDB:masterfrom
estebanzimanyi:postgis_3.6

Conversation

@estebanzimanyi
Copy link
Copy Markdown
Member

@estebanzimanyi estebanzimanyi commented Aug 24, 2025

No description provided.

@mschoema
Copy link
Copy Markdown
Member

mschoema commented Aug 27, 2025

Why do the results of the test change so much? For example, the results of eCovers or aCovers change from 0 to 400+. This seems like either there was a bug before or there is one now, but I'd like to know which one it is.

@estebanzimanyi
Copy link
Copy Markdown
Member Author

estebanzimanyi commented Aug 28, 2025

Indeed, the previous version was erroneous. In the example below, the previous version for aContains was actually performing eContains, e.g., answered true when at least one point was inside the polygon. This is corrected now.

Previous version

$ git branch
* master
[...]
$ psql test
psql (18beta3)
Type "help" for help.

test=# SELECT aContains(geometry 'Polygon((0 0,0 2,2 2,2 0,0 0))', tgeompoint '{POINT(1 1)@2000-01-01,POINT(3 3)@2000-01-02}');
 acontains
-----------
 t

New version

$ git branch
* postgis_3.6
[...]
$ psql test
psql (18beta3)
Type "help" for help.

test=# SELECT aContains(geometry 'Polygon((0 0,0 2,2 2,2 0,0 0))', tgeompoint '{POINT(1 1)@2000-01-01,POINT(3 3)@2000-01-02}');
 acontains
-----------
 f
(1 row)

@mschoema mschoema merged commit 44e1f85 into MobilityDB:master Aug 28, 2025
15 of 16 checks passed
@mschoema mschoema deleted the postgis_3.6 branch August 28, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mschoema mschoema mschoema approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@estebanzimanyi @mschoema