Skip to content

Improve performance problems identified by Issue #679#695

Merged
estebanzimanyi merged 1 commit intoMobilityDB:masterfrom
estebanzimanyi:unary_union
Aug 15, 2025
Merged

Improve performance problems identified by Issue #679#695
estebanzimanyi merged 1 commit intoMobilityDB:masterfrom
estebanzimanyi:unary_union

Conversation

@estebanzimanyi
Copy link
Copy Markdown
Member

Continuation of the PR #694 by @Diviloper

@estebanzimanyi estebanzimanyi requested a review from mschoema August 6, 2025 14:54
Copy link
Copy Markdown
Member

@Diviloper Diviloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the code look good to me, although to be honest I don't know the meaning of half the modified tests 😅.

@estebanzimanyi
Copy link
Copy Markdown
Member Author

The difference comes when using or not ST_UnaryUnion. It introduces many floating point imprecisions that invalidate many of the equality or containment tests. Now the usage of this function is by default set to false.

@estebanzimanyi estebanzimanyi merged commit 055ee09 into MobilityDB:master Aug 15, 2025
16 checks passed
@mschoema mschoema deleted the unary_union branch September 19, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants