Fixes timezone cache free#687
Merged
estebanzimanyi merged 1 commit intoMobilityDB:masterfrom Jul 31, 2025
Merged
Conversation
estebanzimanyi
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
meos_initialize_timezone, if a timezone is already loaded (session_timezoneis notNULL), it is freed. However, the entry that is freed is also the entry that is stored in the cache, so if the new timezone happens to be the same, the new stored timezone is just freed space, that crashes when callingmeos_finalizeor if changing the timezone again withmeos_initialize_timezone.This PR makes the
pg_tzsetfunction to always return a copy of the cached timezone, so it doesn't matter if the returned copy is freed.