Skip to content

Enable Rtree for all bounding boxes#686

Merged
mschoema merged 5 commits intoMobilityDB:masterfrom
estebanzimanyi:rtree
Aug 17, 2025
Merged

Enable Rtree for all bounding boxes#686
mschoema merged 5 commits intoMobilityDB:masterfrom
estebanzimanyi:rtree

Conversation

@estebanzimanyi
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@mschoema mschoema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should keep this for 1.4. The implementation is in my opinion not complete, and we shouldn't add it half-baked to 1.3.

@estebanzimanyi
Copy link
Copy Markdown
Member Author

Perfect to leave it for 1.4. I will correct the issues in a forthcoming PR.

@estebanzimanyi
Copy link
Copy Markdown
Member Author

I'm wondering if we should keep this for 1.4. The implementation is in my opinion not complete, and we shouldn't add it half-baked to 1.3.

IMHO the last commit solved all issues. The changes of this PR basically does not change the algorithm only enable bounding boxes of varying sizes. For me it still can go in 1.3.

@mschoema
Copy link
Copy Markdown
Member

IMHO the last commit solved all issues. The changes of this PR basically does not change the algorithm only enable bounding boxes of varying sizes. For me it still can go in 1.3.

Fair, the RTrees are already there anyway. I still think there are things left to do, but this PR can already be added to 1.3-alpha1. Maybe I'll find the time to improve the RTrees further before the actual 1.3 release.

@estebanzimanyi
Copy link
Copy Markdown
Member Author

IMHO the last commit solved all issues. The changes of this PR basically does not change the algorithm only enable bounding boxes of varying sizes. For me it still can go in 1.3.

Fair, the RTrees are already there anyway. I still think there are things left to do, but this PR can already be added to 1.3-alpha1. Maybe I'll find the time to improve the RTrees further before the actual 1.3 release.

Thanks ! This enables to be used for other bindings, in particular DuckDB.

@mschoema mschoema merged commit 392e1fb into MobilityDB:master Aug 17, 2025
15 of 16 checks passed
@mschoema mschoema deleted the rtree branch August 17, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants