Implementation of the trgeo type#665
Merged
mschoema merged 2 commits intoMobilityDB:masterfrom Apr 8, 2025
Merged
Conversation
Member
estebanzimanyi
commented
Apr 6, 2025
- Initial implementation, will be completed in subsequent PRs
mschoema
approved these changes
Apr 8, 2025
Comment on lines
+132
to
+138
| if(RGEO) | ||
| message(STATUS "Including rigid geometries") | ||
| add_definitions(-DRGEO=1) | ||
| else() | ||
| message(STATUS "Excluding rigid geometries") | ||
| add_definitions(-DRGEO=0) | ||
| endif() |
Member
There was a problem hiding this comment.
If DRGEO is enabled we need to also enable DPOSE, since it can't work without it. Something more should be added here to make sure we don't have DPOSE disabled when DRGEO is enabled.
Member
There was a problem hiding this comment.
I'm accepting this PR, we can fix this in the next one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.