Definition of the tcbuffer type#652
Merged
mschoema merged 8 commits intoMobilityDB:masterfrom Feb 7, 2025
Merged
Conversation
ce1ed46 to
ccf2361
Compare
mschoema
requested changes
Feb 4, 2025
ccf2361 to
e7e4166
Compare
e7e4166 to
94e8696
Compare
mschoema
requested changes
Feb 5, 2025
meos/src/cbuffer/cbuffer.c
Outdated
| getPoint4d_p(ring->points, 0, &p1); | ||
| getPoint4d_p(ring->points, 1, &p2); | ||
| double radius = (p2.x - p1.x) / 2; | ||
| LWGEOM *center = (LWGEOM *) lwpoint_make2d(srid, p1.x + radius, p1.y + radius); |
Member
There was a problem hiding this comment.
I believe this is still incorrect. p1.x + radius, p1.y + radius is not always the center of the circle. For example, if the circle is defined using the following 3 points: (1 0, 0 0, 1 0). I think the center should be computed by linear interpolation between point 1 and 2.
1e90446 to
5ac4314
Compare
mschoema
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.