Skip to content

Improve cmake code for mobilitydb_datagen extension#651

Merged
mschoema merged 4 commits intoMobilityDB:masterfrom
mschoema:datagen_sql
Feb 4, 2025
Merged

Improve cmake code for mobilitydb_datagen extension#651
mschoema merged 4 commits intoMobilityDB:masterfrom
mschoema:datagen_sql

Conversation

@mschoema
Copy link
Copy Markdown
Member

@mschoema mschoema commented Feb 2, 2025

This is the first in a set of PRs to improve the CMake code of MobilityDB and MEOS.
Major changes in this PR:

  • Update cmake_minimum_required from 3.7 to 3.12 (needed for other changes in the PR).
  • Rename the .control files to .in.control.
  • Add a header.in.sql file for the datagen extension. This file contains the license, a notice that the extension sql file is auto-generated, and the line to prevent manually sourcing the file in psql.
  • Improve generation of extension sql file: First configure header, then append all needed sql file after removing their license (the header already contains the license).
  • Remove unused files (control.in, test.sql)

@mschoema
Copy link
Copy Markdown
Member Author

mschoema commented Feb 2, 2025

@estebanzimanyi
I also added the random_geo.sql file in the list of sql files for mobilitydb_datagen, since it is needed by the other files.
Was there a reason not to include it in the first place?

estebanzimanyi
estebanzimanyi previously approved these changes Feb 2, 2025
View reviewed changes
@mschoema
Copy link
Copy Markdown
Member Author

mschoema commented Feb 3, 2025

@estebanzimanyi I also added the random_geo.sql file in the list of sql files for mobilitydb_datagen, since it is needed by the other files. Was there a reason not to include it in the first place?

I thought we needed random_geo.sql, because random_int and random_float are defined in there, but they are also defined in random_temporal.sql, so the file is actually not needed. Removed it for now.

@mschoema mschoema merged commit 805f94d into MobilityDB:master Feb 4, 2025
@mschoema mschoema deleted the datagen_sql branch February 4, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebanzimanyi estebanzimanyi estebanzimanyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mschoema @estebanzimanyi