Skip to content

Add cast tbool -> tint#645

Merged
mschoema merged 1 commit intoMobilityDB:masterfrom
estebanzimanyi:tbool_tint
Jan 8, 2025
Merged

Add cast tbool -> tint#645
mschoema merged 1 commit intoMobilityDB:masterfrom
estebanzimanyi:tbool_tint

Conversation

@estebanzimanyi
Copy link
Copy Markdown
Member

No description provided.

@mschoema
Copy link
Copy Markdown
Member

mschoema commented Jan 8, 2025

This might be overkill, but if we want to optimize this function we could just do a temporal_copy and then overwrite all temptype values in a single loop. This works, because the memory representation of true / false is the same as 1 / 0 (at least should be, not sure about endianness problems).

@mschoema
Copy link
Copy Markdown
Member

mschoema commented Jan 8, 2025

Ah nvm, we still need to change the bbox type. This optimization is probably not worth the effort and maintenance cost.

@mschoema mschoema merged commit 096b7f4 into MobilityDB:master Jan 8, 2025
@mschoema mschoema deleted the tbool_tint branch January 8, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants