Merged
Conversation
Member
estebanzimanyi
commented
Sep 28, 2024
- List global variables and constants
65e6970 to
afb228e
Compare
mschoema
requested changes
Oct 2, 2024
Member
mschoema
left a comment
There was a problem hiding this comment.
I only commented on the global variable handling, but the cppcheck changes are ok.
61f0597 to
fcf8b16
Compare
mschoema
requested changes
Oct 4, 2024
Member
There was a problem hiding this comment.
These changes revert the changes made to tpoint_rtree.c in a previous PR
9976370 to
0c9f78d
Compare
mschoema
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.