Updated meos.h to include extern keyword#552
Merged
estebanzimanyi merged 1 commit intoMobilityDB:masterfrom Aug 2, 2024
Merged
Updated meos.h to include extern keyword#552estebanzimanyi merged 1 commit intoMobilityDB:masterfrom
estebanzimanyi merged 1 commit intoMobilityDB:masterfrom
Conversation
extern keyword is required by JMEOS ffi for pattern matching during the function extraction process.
estebanzimanyi
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JMEOS and other FFI that use regex pattern matching for extracting functions from the meos header file require an extern keyword in the function signature. Therefore, adding an extern keyword to all the temporal functions that do not have that results in uniform function extraction across FFIs.