Make some pointers in the parameters constant#546
Merged
mschoema merged 4 commits intoMobilityDB:masterfrom Aug 2, 2024
Merged
Make some pointers in the parameters constant#546mschoema merged 4 commits intoMobilityDB:masterfrom
mschoema merged 4 commits intoMobilityDB:masterfrom
Conversation
Davichet-e
commented
Jul 31, 2024
Member
|
Regarding PyMEOS, this shouldn't affect the wrapper at all, so no worries in that regard. |
Member
Author
|
I just realised I didn't change the declarations in the meos.h file and some more changes are needed, working on it. Will also add more consts |
mschoema
requested changes
Aug 1, 2024
Member
Author
|
Forgot to check the examples, will do now |
mschoema
reviewed
Aug 1, 2024
Member
Author
|
Checked the examples, no warning were generated when compiling them |
Member
Author
|
Sorry for the messy commit message, I forgot if you put a string between ``, it executes the command with that name. It shouldn't matter since I guess we will rebase and will just squash all of the commits into one. |
Davichet-e
commented
Aug 1, 2024
mschoema
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make some pointers in the parameters constant
Fixes #545.
Testing
I built MEOS and it completed succesfully
Unknowns
PyMEOS(confirmed with author) or JMEOS that would make this change a breaking change?