Solve issue when inserting a point along a non-manifold edge with 2 singular extremities#287
Merged
corentin-prigent merged 1 commit intodevelopfrom Oct 29, 2024
Merged
Conversation
…edge with 2 singular extremities. If we return 1. The point is inserted along the nom edge but its normals have not been computed (so they can be NaN).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #287 +/- ##
========================================
Coverage 50.45% 50.45%
========================================
Files 177 177
Lines 47239 47239
Branches 10272 10272
========================================
+ Hits 23834 23836 +2
+ Misses 15673 15671 -2
Partials 7732 7732 ☔ View full report in Codecov by Sentry. |
Contributor
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the return value when BezierNom is called along a non-manifold edge with 2 singular extremities.
If we return 1. The point is inserted along the nom edge but its normals have not been computed (so they can be NaN).
An example of error can be found when running the
ls-DisIn-cubegeom-metric-fields-5test case of ParMmg.