Feature/fix vtk install deadlock in ci#286
Merged
corentin-prigent merged 3 commits intodevelopfrom Oct 22, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #286 +/- ##
========================================
Coverage 50.44% 50.44%
========================================
Files 177 177
Lines 47238 47238
Branches 10271 10272 +1
========================================
Hits 23830 23830
Misses 15676 15676
Partials 7732 7732 ☔ View full report in Codecov by Sentry. |
Contributor
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the macos-12 runners by macos-14 ones for jobs with VTK enabled.
It fixes a recent deadlock (or very long slowdown) during the installation of VTK using homebrew (see https://github.com/MmgTools/mmg/actions/runs/11384817386/job/31673334951) which is probably due to the removal of the macos-12 runner in a close future.
Integrating this PR should allow to fix the github-actions of PR #285.