Fix storage of tags in MMG5_swap23#283
Merged
Algiane merged 7 commits intoMmgTools:developfrom Sep 24, 2024
Merged
Conversation
…ite of pt1 by memcpy
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #283 +/- ##
===========================================
- Coverage 50.44% 50.44% -0.01%
===========================================
Files 177 177
Lines 47236 47238 +2
Branches 10271 10271
===========================================
Hits 23830 23830
- Misses 15674 15676 +2
Partials 7732 7732 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update fixes the way tags are applied to newly created tetras in
MMG5_swap23. Several calls ofMMG3D_get_shellEdgeTagare added in order to provide complete data to new tetras. These calls must be performed before the call ofmemcpyfunction since this call overwrites data about the initial tetra.This update is motivated by the need to improve the behaviour of
parMmgcontinuous integration tests.