Modification of tag transmission from edges to faces in analysis#277
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #277 +/- ##
========================================
Coverage 50.44% 50.45%
========================================
Files 176 176
Lines 47200 47222 +22
Branches 10261 10265 +4
========================================
+ Hits 23811 23825 +14
- Misses 15664 15669 +5
- Partials 7725 7728 +3 ☔ View full report in Codecov by Sentry. |
Algiane
left a comment
There was a problem hiding this comment.
Thanks,
Please, can you check my comments and rerun the ParMmg checks with the suitable fix if it makes sense ?
Best
Algiane
left a comment
There was a problem hiding this comment.
Thanks,
Just a small note: If we really wanted to do things properly, we would have had to add 3 unit tests to cover this line: each of the tests calling the function on a hard-defined tetra with one of the erroneous tags on one of its faces. The test would be considered as successful if it fails inside the assertion in debug mode.
In function
MMG5_bdrySet, if all three edges of a face share a given tag, this tag is given to the face (fieldxt->ftag[]). Some edge tags do not make sense when applied to a face (MG_GEO or/and MG_NOM). This could cause bugs in splits when a newly create edge wrongly received such tags from a face. This update removes such nonsensical tags.