Feature/required vertices preservation#273
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #273 +/- ##
===========================================
+ Coverage 50.47% 51.26% +0.78%
===========================================
Files 174 176 +2
Lines 47158 49124 +1966
Branches 10255 11449 +1194
===========================================
+ Hits 23802 25181 +1379
- Misses 15633 15934 +301
- Partials 7723 8009 +286 ☔ View full report in Codecov by Sentry. |
ea4a796 to
662302f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
xregoption (regularization of the position of boundary vertices) was not preserving required vertices. The current PR:cmake/testing/code/req-vert-3d.c)xreqoption.