use fgets() results when reading .mesh files, plus language fixes#271
Merged
Algiane merged 1 commit intoMmgTools:developfrom May 17, 2024
Merged
use fgets() results when reading .mesh files, plus language fixes#271Algiane merged 1 commit intoMmgTools:developfrom
Algiane merged 1 commit intoMmgTools:developfrom
Conversation
The .mesh reader uses fgets() to skip comments (until end of line) but did not check the result, so it would not have noticed anything in the unlikely case of a comment line longer than MMG5_FILESTR_LGTH = 128. This commit lets fgets be called repeatedly until EOL or EOF is encountered. This also avoids a compiler warning on each library. Using getline() would be easier but that is not standard C.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #271 +/- ##
===========================================
- Coverage 50.47% 50.46% -0.01%
===========================================
Files 174 174
Lines 47158 47167 +9
Branches 10259 10265 +6
===========================================
Hits 23802 23802
- Misses 15633 15641 +8
- Partials 7723 7724 +1 ☔ View full report in Codecov by Sentry. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .mesh reader uses fgets() to skip comments (until end of line) but did
not check the result, so it would not have noticed anything in the
unlikely case of a comment line longer than MMG5_FILESTR_LGTH = 128 characters.
This commit lets fgets be called repeatedly until EOL or EOF is encountered.
This also avoids a compiler warning on each library.
Using getline() would be easier but that is not standard C.