Skip to content

Make FindScotch module respect QUIET#264

Merged
Algiane merged 1 commit intoMmgTools:masterfrom
jcortial-safran:cmake-find-scotch-quiet
Apr 25, 2024
Merged

Make FindScotch module respect QUIET#264
Algiane merged 1 commit intoMmgTools:masterfrom
jcortial-safran:cmake-find-scotch-quiet

Conversation

@jcortial-safran
Copy link
Copy Markdown
Contributor

CMAKE_REQUIRED_QUIET must be set to make check_function_exists and check_c_source_runs quiet as well.

CMAKE_REAUIRED_QUIET must be set to make `check_function_exists`
and `check_c_source_runs` quiet as well.
@jcortial-safran
Copy link
Copy Markdown
Contributor Author

Thanks @Algiane ! Would it be possible to merge the PR ?

Also, do you plan to make a release at some point ?

@Algiane Algiane merged commit fe5ce20 into MmgTools:master Apr 25, 2024
@Algiane
Copy link
Copy Markdown
Member

Algiane commented Apr 25, 2024

Hi @jcortial-safran ,

We are planning a release for November at the latest. It will not bring new features but will improve:

  • the robustness of Mmg3d in presence of non-manifold geometries (thanks to the debugging work of @coprigent for the MICORCARD project);
  • the developer documentation (thanks to the contribution of @mpotse).

Best,

@prj-
Copy link
Copy Markdown
Contributor

prj- commented Apr 25, 2024

Please keep develop in sync.

@jcortial-safran
Copy link
Copy Markdown
Contributor Author

Hi @jcortial-safran ,

We are planning a release for November at the latest. It will not bring new features but will improve:

  • the robustness of Mmg3d in presence of non-manifold geometries (thanks to the debugging work of @coprigent for the MICORCARD project);
  • the developer documentation (thanks to the contribution of @mpotse).

Best,

Sounds good !

Would it be possible to make a patch release (such as version 5.7.3) in the meantime ?

@Algiane Algiane added kind: enhancement enhancement to an existing feature part: cmake cmake part labels Apr 25, 2024
@jcortial-safran jcortial-safran deleted the cmake-find-scotch-quiet branch April 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: enhancement enhancement to an existing feature part: cmake cmake part

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants