Skip to content

Correctly find dependencies when installed#261

Merged
Algiane merged 1 commit intoMmgTools:masterfrom
jcortial-safran:cmake-find-dependency
Apr 22, 2024
Merged

Correctly find dependencies when installed#261
Algiane merged 1 commit intoMmgTools:masterfrom
jcortial-safran:cmake-find-dependency

Conversation

@jcortial-safran
Copy link
Copy Markdown
Contributor

@jcortial-safran jcortial-safran commented Apr 19, 2024

Use find_dependency instead of find_package in installed CMake config to correctly propagate QUIET and REQUIRED flags to users.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jcortial-safran jcortial-safran changed the base branch from develop to master April 20, 2024 14:51
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@bae2c83). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #261   +/-   ##
=========================================
  Coverage          ?   43.98%           
=========================================
  Files             ?      179           
  Lines             ?    54124           
  Branches          ?    10252           
=========================================
  Hits              ?    23805           
  Misses            ?    22599           
  Partials          ?     7720

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane self-assigned this Apr 22, 2024
@Algiane Algiane added kind: enhancement enhancement to an existing feature part: cmake cmake part labels Apr 22, 2024
Algiane
Algiane approved these changes Apr 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Algiane Algiane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Algiane Algiane merged commit f7d154c into MmgTools:master Apr 22, 2024
@jcortial-safran jcortial-safran deleted the cmake-find-dependency branch April 22, 2024 13:10
@jcortial-safran
Copy link
Copy Markdown
Contributor Author

jcortial-safran commented May 3, 2024

The change had the unfortunate side-effect to make the CMake configuration fail whenever either SCOTCH or VTK are absent, even if these packages were not used when building Mmg. So it is a significant regression compared to the previous state.

Sorry for that, I should have tested more throughly. I will submit a fix as a new PR.

@Algiane
Copy link
Copy Markdown
Member

Algiane commented May 3, 2024

Thanks for the feedback.

I haven't particularly tested the PR as the integration tests didn't fail but the config files generated by CMake are not tested 😅 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algiane Algiane Algiane approved these changes

Assignees

@Algiane Algiane

Labels

kind: enhancement enhancement to an existing feature part: cmake cmake part

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jcortial-safran @CLAassistant @Algiane