Skip to content

libmmg3d_private.h: include inttypes.h for PRId#240

Merged
Algiane merged 1 commit intoMmgTools:masterfrom
barracuda156:darwin
Jan 30, 2024
Merged

libmmg3d_private.h: include inttypes.h for PRId#240
Algiane merged 1 commit intoMmgTools:masterfrom
barracuda156:darwin

Conversation

@barracuda156
Copy link
Copy Markdown
Contributor

@barracuda156 barracuda156 commented Jan 30, 2024

The code uses PRId* macros without including a header and define needed for those.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@barracuda156
Copy link
Copy Markdown
Contributor Author

barracuda156 commented Jan 30, 2024

Otherwise this may happen:

In file included from /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_science_mmg/mmg/work/mmg-5.7.2/src/mmg3d/inoutcpp_3d.cpp:38:
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_science_mmg/mmg/work/mmg-5.7.2/src/mmg3d/libmmg3d_private.h: In function ‘void MMG5_warnOrientation(MMG5_Mesh*)’:
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_science_mmg/mmg/work/mmg-5.7.2/src/mmg3d/libmmg3d_private.h:530: error: expected `)' before ‘PRId32’
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_science_mmg/mmg/work/mmg-5.7.2/src/mmg3d/libmmg3d_private.h:531: warning: spurious trailing ‘%’ in format
make[2]: *** [CMakeFiles/libmmg_so.dir/src/mmg3d/inoutcpp_3d.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....

@Algiane Algiane merged commit b899536 into MmgTools:master Jan 30, 2024
@Algiane
Copy link
Copy Markdown
Member

Algiane commented Jan 30, 2024

Thanks for this fix!

@Algiane Algiane added kind: bug error or fault part: compilation compilation related labels Jan 30, 2024
@barracuda156
Copy link
Copy Markdown
Contributor Author

barracuda156 commented Jan 30, 2024

@Algiane Thank you for merging!

@prj-
Copy link
Copy Markdown
Contributor

prj- commented Jan 30, 2024

Please keep develop in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algiane Algiane Algiane approved these changes

Assignees

No one assigned

Labels

kind: bug error or fault part: compilation compilation related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@barracuda156 @CLAassistant @Algiane @prj-