Merged
Conversation
Fix possible invalid pointer in MMG3D_movbdyregpt_iso after the reallocation of the xpoint array by the MMG3D_movbdyregpt_geom function.
If all tetra (resp. points) are deleted, the last deletion (iel == mesh->ne) leads to mesh->ne = -1 (resp. mesh->np = -1) and to a memory error if we don't add a security guard. See for example the `mmg3d_hybrid-nsd1` continuous integration test with PATTERN and SCOTCH options setted to off.
Add to prilen funcs: - the check that the metric is allocated (avoid memory errors in ParMmg when calling computePrilen) - the check that the element array is not empty (avoid infinite edge lengths when mesh->nt = 0, for example after domain deletion)
Fix possibly invalid pointer
Add to prilen funcs: - the check that the metric is allocated (avoid memory errors in ParMmg when calling computePrilen) - the check that the element array is not empty (avoid infinite edge lengths when mesh->nt = 0, for example after domain deletion)
…s/mmg into feature/fix-edgeLength-in-ParMmg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
return 0at the beginning of theprilenfunctions if called without metric;The aim of 1. is to avoid memory issue when calling
prilen(edge lengths computations are not intended to be launch without metric): see ParMmg PR102.The aim of 2. is to avoid infinite edge lengths when histogram is called with no edges/elements (see continuous integration test
mmg2d_hybrid-nsd1where all triangles are deleted from the mesh and the edge length histo is called before remeshing).