Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix-collapse.tar.gz
Modified checks in MMG5_chkcol_bdy to prevent some unwanted collapses.
Several files are attached.
ctest-logs-devel.txtandctest-logs-fix.txtcontain the logs of the continuous integration tests for both the unfixed (devel) and fixed versions of the code. Only mmg3d tests have been run (long tests included). For these tests, mmg has been compiled inReleasemode, with32-bit integers.Scotchis used in sequential mode (BUILD_PTSCOTCH=OFF) for reproducibility. Computing times are similar and adaptation waves are strictly identical with or without the fix.test-devel.logandtest-fix.logare the output of mmg for the following test (download input mesh):The CoquilFace warning that appears in the devel version has been successfully removed with this update. However, another similar warning appears later in the remeshing process, which requires further investigation and will be the object of future update.
The configuration of interest for this update is as illustrated in the picture:

The collapse that is represented on the picture (point ip over point iq) merges two manifold edges that each possess exactly two boundary faces (hatched triangles on the picture). Hence, the collapse results in a non-manifold edge since there are now four boundary triangles in the shell of the edge. The modification of the topology of the mesh being unwanted, some tests have been modified in order to refuse such a collapse.