Skip to content

Feature/pmmg issue97#222

Merged
Algiane merged 2 commits intodevelopfrom
feature/pmmg-issue97
Jul 20, 2023
Merged

Feature/pmmg issue97#222
Algiane merged 2 commits intodevelopfrom
feature/pmmg-issue97

Conversation

@Algiane
Copy link
Copy Markdown
Member

@Algiane Algiane commented Jul 20, 2023

This PR replaces the use of the tmp point field in the setVertexNmTag function by the use of a temporary array.

For Mmg it should not change anything but it fixes the issue introduced in the parallel analysis of ParMmg by the modification of the tmp field (that is used to store the global node numbering and should not be modified before, at least, the end of the normal computation).

See ParMmg issue 97

Algiane added 2 commits July 20, 2023 15:07
…tmp point's fields: this field is used in the distributed analysis of ParMmg (that calls setVertexNmTag too) and has to be preserved.
… to skip points for which the function returns 1 (in Mmg we want to skip parbdy points while in ParMmg we want to skip all points that are not old parallel boundaries).
@Algiane Algiane added kind: refactoring needs refactoring part: mmg3d mmg3d specific labels Jul 20, 2023
@Algiane Algiane merged commit aa5ac04 into develop Jul 20, 2023
@Algiane Algiane deleted the feature/pmmg-issue97 branch December 1, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: refactoring needs refactoring part: mmg3d mmg3d specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant