Skip to content

Feature/pmmg issue97#219

Merged
Algiane merged 1 commit intodevelopfrom
feature/pmmg-issue97
Jun 30, 2023
Merged

Feature/pmmg issue97#219
Algiane merged 1 commit intodevelopfrom
feature/pmmg-issue97

Conversation

@Algiane
Copy link
Copy Markdown
Member

@Algiane Algiane commented Jun 29, 2023

Re-introduction of boulernm function for fast-fix of ParMmg compilation with the develop branch of Mmg.

⚠️ As it is not efficient, this function has to be removed and the new setVertexNmTag function of Mmg as to be used instead. For now it is not possible because boulernm was probably bugged (to be confirmed) and some 'regular' non-manifold points where marked as corner+required. Removing these erroneous tags raises errors in the parallel surface analysis of ParMmg (it has to be investigated).

@Algiane Algiane added the kind: bug error or fault label Jun 29, 2023
@Algiane Algiane linked an issue Jun 29, 2023 that may be closed by this pull request
@Algiane Algiane changed the base branch from master to develop June 30, 2023 09:19
@Algiane Algiane merged commit 3e7a720 into develop Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: bug error or fault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_MMG5_boulernm removal

1 participant