Skip to content

Feature/fix boulernm efficiency#217

Merged
Algiane merged 3 commits intodevelopfrom
feature/fix-boulernm-efficiency
Jun 13, 2023
Merged

Feature/fix boulernm efficiency#217
Algiane merged 3 commits intodevelopfrom
feature/fix-boulernm-efficiency

Conversation

@Algiane
Copy link
Copy Markdown
Member

@Algiane Algiane commented Jun 13, 2023

This PR rewrites the setVertexNmTag (function that analysis the type of feature edges arriving through a non-required non-manifold point and set the suitable tag at point):

  • initial function was travelling the tetra vertices, selecting the edges of the ball of the vertex incident to the vertex and counting the feature edges (edges where hashed in a new hash table for each vertex to be uniquely added);
  • now we travel tetra edges and increment edge vertices counters depending on the type of the feature edges. Edges are hashed to be uniquely added. Then we travel the mesh points and set the suitable tags depending on the computed counters.

This PR removes the boulernm function.

@Algiane Algiane added kind: enhancement enhancement to an existing feature part: mmg3d mmg3d specific labels Jun 13, 2023
@Algiane Algiane merged commit 5a1baa5 into develop Jun 13, 2023
@Algiane Algiane deleted the feature/fix-boulernm-efficiency branch June 13, 2023 07:52
@prj-
Copy link
Copy Markdown
Contributor

prj- commented Jun 17, 2023

@Algiane, this PR breaks ParMmg.

Undefined symbols for architecture arm64:
  "_MMG5_boulernm", referenced from:
      _PMMG_update_singul in analys_pmmg.c.o

@Algiane
Copy link
Copy Markdown
Member Author

Algiane commented Jun 19, 2023

Thanks for this report. I will try to fix this as soon as possible (I am in business travel for now).

@Algiane Algiane mentioned this pull request Jun 29, 2023
Closed
@Algiane
Copy link
Copy Markdown
Member Author

Algiane commented Jun 30, 2023

Hi,
Thanks for your patience. I have merged a temporary fix in Mmg (see issue #97 ).
I hope that it will work while we wait for a real solution to the problem.
Best

@prj-
Copy link
Copy Markdown
Contributor

prj- commented Jun 30, 2023

Yes, it does work, thanks.

@prj-
Copy link
Copy Markdown
Contributor

prj- commented Jul 3, 2023

Sorry, I spoke too soon. Though now ParMmg builds successfully, it fails a very basic FreeFEM test with the following error.

Assertion failed: (isfinite(dd)), function PMMG_hashNorver_normals, file analys_pmmg.c, line 990.

@Algiane
Copy link
Copy Markdown
Member Author

Algiane commented Jul 4, 2023

Hi,

Sorry for that. I will try to find this issue before the summer hollidays.

Best

@prj-
Copy link
Copy Markdown
Contributor

prj- commented Jul 5, 2023

No problem, in the meantime, I'm sticking to commit 6824158449e57b46253b505d968b81f15fafc6a0 of Mmg. Let me know if you want me to try something that you cooked up, there is no hurry at all, I'll still be here after the summer holidays :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind: enhancement enhancement to an existing feature part: mmg3d mmg3d specific

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Algiane @prj-