Fast fix of unefficiency or the setVertexNmTag function visible only …#216
Merged
Fast fix of unefficiency or the setVertexNmTag function visible only …#216
Conversation
…for a high number of nm points (due to boulernm unefficiency).
Algiane
commented
Jul 20, 2023
| else if ( ph->a ) { | ||
| while ( ph->nxt && ph->nxt < hash->max ) { | ||
| ph = &hash->item[ph->nxt]; | ||
| if ( ph->a == ia && ph->b == ib ) continue; |
Member
Author
There was a problem hiding this comment.
Remark: This erroneous continue was leading to add a new edge in the hash table even if this edge was already listed. In consequence, the counted number of non-manifold edges was sometime greater than the real nomber of nm edges passing through the point, leading to add spurious required vertices.
See the attached example where 2 spurious required vertices are added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…for a high number of nm points (due to boulernm unefficiency).