Feature/fix missing bdy ppt tag for parmmg+ls#212
Merged
Conversation
After this commit we do not test anymore if we are in iso mode to add boundary point tags in chkBdryTria func: - it should change nothing in Mmg as: i/ in iso mode all bdy point tags are removed at the end of the ls discretization step and recreated during the reconstruction of boundary triangles (all boundary triangles are removed too); ii/ in adaptation mode, the boundary point tags are normally added; - it should fix commit 86e1ff5 of ParMmg (test `ls-DisIn-ReadLs-*`) that fails due to the fact that we are in ls mode but the ls step is not yet implemented (so boundary triangles are not missing and boundary tag at points are never added).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remove a useless test on the iso mode: in iso mode, the MG_BDY tag at bdry points was not added during the call of the chkBdryTria function. It was not an issue as this tag is setted during the step of reconstruction of boundary tria from xtetra.