src/modes/cclip/run.rs (1)

1070-1088: Consider extracting duplicate item reconstruction logic.

This item reconstruction block (converting CclipItem to Item with formatting) is repeated in at least three places: here (deletion), tag application (lines 1301-1319), and tag removal (lines 1390-1408). Extracting this to a helper function would improve maintainability.

src/core/debug_logger.rs (1)

51-52: Consider using compile-time format descriptions for slight efficiency gain.

The current approach parses format descriptions at runtime. While the .unwrap() is safe here since the format strings are known-valid, using time::macros::format_description! would be slightly more efficient by parsing at compile time.

♻️ Optional: Use compile-time format descriptions

+use time::macros::format_description;
+
+// At module level or as constants:
+const DATETIME_FORMAT: &[time::format_description::FormatItem<'static>] = 
+    format_description!("[year]-[month]-[day] [hour]:[minute]:[second].[subsecond digits:3]");
+const FILENAME_FORMAT: &[time::format_description::FormatItem<'static>] = 
+    format_description!("[year][month][day]-[hour][minute][second]");

// Then use:
-        time::OffsetDateTime::now_local().unwrap_or_else(|_| time::OffsetDateTime::now_utc())
-            .format(&time::format_description::parse("[year]-[month]-[day] [hour]:[minute]:[second].[subsecond digits:3]").unwrap()).unwrap()
+        time::OffsetDateTime::now_local().unwrap_or_else(|_| time::OffsetDateTime::now_utc())
+            .format(&DATETIME_FORMAT).unwrap()

src/modes/app_launcher/launch.rs (1)

37-48: Consider extracting history/frecency recording to a helper function.

The history and frecency recording logic is duplicated between the TTY path (lines 37-48) and the non-TTY path (lines 141-152). While the placement differs by necessity (before exec vs. after spawn), the logic is identical.

♻️ Suggested helper function

fn record_launch(db: &std::sync::Arc<redb::Database>, app_name: &str, history: i64) -> Result<()> {
    let value = history + 1;
    let write_txn = db.begin_write()?;
    {
        let mut table = write_txn.open_table(crate::core::cache::HISTORY_TABLE)?;
        table.insert(app_name, value)?;
    }
    write_txn.commit()?;

    if let Err(e) = crate::core::database::record_access(db, app_name) {
        eprintln!("Warning: Failed to update frecency: {}", e);
    }
    Ok(())
}

Then use it in both paths:

-        // Record history and frecency BEFORE exec since we disappear after
-        let value = app.history + 1;
-        let write_txn = db.begin_write()?;
-        {
-            let mut table = write_txn.open_table(crate::core::cache::HISTORY_TABLE)?;
-            table.insert(app.name.as_str(), value)?;
-        }
-        write_txn.commit()?;
-
-        if let Err(e) = crate::core::database::record_access(db, &app.name) {
-            eprintln!("Warning: Failed to update frecency: {}", e);
-        }
+        // Record history and frecency BEFORE exec since we disappear after
+        record_launch(db, &app.name, app.history)?;

src/core/debug_logger.rs (2)

25-30: Consider using compile-time format description macro.

The time crate provides time::macros::format_description! for compile-time validation, which eliminates runtime parsing and the associated .unwrap() calls.

♻️ Suggested refactor using compile-time macro

+use time::macros::format_description;
+
+// At module level or as consts:
+const FILENAME_FMT: &[time::format_description::FormatItem<'static>] =
+    format_description!("[year][month][day]-[hour][minute][second]");

Then at the call site:

 let now = time::OffsetDateTime::now_local().unwrap_or_else(|_| time::OffsetDateTime::now_utc());
-let timestamp = now
-    .format(
-        &time::format_description::parse("[year][month][day]-[hour][minute][second]").unwrap(),
-    )
-    .unwrap();
+let timestamp = now.format(&FILENAME_FMT).unwrap();

---

55-63: Duplicated format string; consider extracting to a constant.

This exact format string is repeated at line 253 for log_session_end(). Extracting it to a shared constant (ideally using the compile-time macro) would improve maintainability.

♻️ Suggested extraction

use time::macros::format_description;

const TIMESTAMP_FMT: &[time::format_description::FormatItem<'static>] =
    format_description!("[year]-[month]-[day] [hour]:[minute]:[second].[subsecond digits:3]");

Then use &TIMESTAMP_FMT in both locations.

Cargo.toml (1)

28-29: Document time 0.3 local-offset platform constraints before deployment.

time crate's local-offset feature has well-documented platform-specific behavior on supported targets:

• Linux: requires process to be single-threaded (checked via /proc/self/stat); returns IndeterminateOffset error in multi-threaded contexts
• BSD & other Unix: safe implementation gracefully returns error; local offset detection only succeeds if timezone is configured via /etc/localtime backed by /usr/share/zoneinfo

Ensure error handling is in place for calls to OffsetDateTime::now_local() and similar APIs, especially if multi-threading is enabled on Linux or custom timezone setups are used on BSD systems. The unsound escape hatch --cfg unsound_local_offset should not be used (explicitly unsound, potential segfaults).

directories 6.0 is compatible; its changes are limited to dependency updates.