Fix offset calculation to avoid losing offset record updates. Thanks to @HyprCoder for the fix.#542
Merged
jonathanstegall merged 3 commits intoMinnPost:masterfrom Oct 9, 2024
Conversation
It will be saved to db if the query has results with an additional offset. This way we do not lose records found on check_offset_query
Member
|
@HyprCoder thanks for this, I'll review/test it in the next few days. Just at first glance, this seems like it would be just a patch release, right (version 2.2.11)? I wouldn't mind making it a 2.3 but it doesn't seem that major? I don't notice any migration issues or anything like that. |
Member
|
I think it's likely that this pull request will also fix #341. It seems to me that it's likely that this was the same issue that person was experiencing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
This PR fixes the issue #541 by changing how the offset is calculated to avoid losing record updates when pulling data from SalesForce. I made the following changes:
How do I test this Pull Request?