Add a new filter to prevent new user notifications. Also prevents some possible errors that can happen when plugin options haven't been set. Thanks to @federicojacobi for the pull request.#536
Merged
jonathanstegall merged 7 commits intoMinnPost:masterfrom Jun 19, 2024
Conversation
federicojacobi
commented
May 31, 2024
Comment on lines
+97
to
+98
| $this->statuses_to_log = maybe_unserialize( get_option( $this->option_prefix . 'statuses_to_log', array() ) ); | ||
| $this->statuses_to_log = empty( $this->statuses_to_log ) ? [] : $this->statuses_to_log; |
Author
There was a problem hiding this comment.
There are multiple flavors of this issue, but they all come down to this: when the option doesn't exist or is empty then returned value from get_option is an empty string. Then maybe_unserialize thinks this is an ok value and doesn't return the array set as the default.
Then array functions throw fatals. Ex: in_array
Comment on lines
+1001
to
+1003
| if ( apply_filters( $this->option_prefix . 'send_new_user_notification', true, $user_id, $params ) ) { | ||
| wp_new_user_notification( $user_id, null, 'both' ); | ||
| } |
Author
There was a problem hiding this comment.
It is possible to user the default WP hooks wp_send_new_user_notification_to_admin and wp_send_new_user_notification_to_user but the problem with this is that by the time those hooks run, the developer cannot know where the user came from.
This is particularly bad when doing an "import" of existing contacts into wp ... perhaps you want to import users but not let them know about it.
just for wp code standards, use long declaration for array
I think these are always arrays
more arrays
empty line doesn't seem necessary here
for wp code style, use longhand to declare arrays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
in_arraycalls fatal out. Let's cast them into arrays to be sure. In some cases,maybe_unserializeis not returning the default array values.